Project

General

Profile

Actions

Pull request #280

closed

Update HPP to v4.10, among others

Added by Guilhem Saurel over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Repository URL:
https://github.com/nim65s/robotpkg
Repository branch:
master

Description

Hi,

This one is pretty big, but I wasn't able to incrementally upgrade some packages without all the others.

I expect many issues with 16.04 (mostly about older boost version and GCC bugs), but as all our robots have been upgraded, and our users notified, publishing fixes for this can wait from my point of view.

An interesting point is that by allowing our developers to use C++11, we actually switched to C++14 (auto can't be used in some contexts in C++11), and didn't see it at first as C++14 is the default standard on 18.04.

Therefore, the configuration that forced C++11 on robotpkg raise some issues there. The last 2 commits are a proposition of a workaround for the packages I work on, but this will probably also break other packages on older distro…

The fix I have implemented in our CMake modules is to let the user define a minimal required standard, and check the standard of the current compiler. This ensure that if the default standard is C++14, and the user says that he wants at least C++11, everything works as expected.

I guess it would be easy to add a similar strategy in robotpkg, but didn't work on it yet.

for reference: https://github.com/jrl-umi3218/jrl-cmakemodules/blob/master/cxx-standard.cmake
& https://github.com/jrl-umi3218/jrl-cmakemodules/blob/master/cxx-standard.cpp

Best,
Guilhem.

Actions

Also available in: Atom PDF