Pull request #207
closedUpdate Pinocchio, omniORB, gepetto-viewer-corba & hpp-corbaserver
Description
Hello,
Pinocchio v2.1.3 is available here: https://github.com/nim65s/robotpkg/commit/8928f0e4dd5df3d132ac752922eb9ef99c8275b7
As omniORB & omniORBpy are available on Ubuntu only for python2 (they both have files in ${PYTHON_SITELIB}), I suggest to add a PKGTAG.python to their name, to provide a Python 3 binary version for Ubuntu. Otherwise, most of gepetto-viewer & hpp would not be usable in Python 3, even if they compile and install correctly.
The patch is here: https://github.com/nim65s/robotpkg/commit/0730604de8f6510f62177c6b120a5029e8a0ea37
Also, we found issues with the new omniidl python backend that exposes docstrings: docstrings are not writable in our case on Python 2, so here are patches for:
- gepetto-viewer-corba: https://github.com/nim65s/robotpkg/commit/32434c7f3e47d3e162544b88a3cacf939699fc80
- hpp-corbaserver: https://github.com/nim65s/robotpkg/commit/d5ba00c2575c7542091e5ceddb627eb0fbbf1a66
Then, while testing that, I also found that omniORB 4.2.2 on Python 3 was not building on Arch, probably because of Python 3.7 related issue, so I also suggest to update to 4.2.3:
- omniORB: https://github.com/nim65s/robotpkg/commit/c22a520887e79540309830213c42b279f113aa39
- omniORBpy: https://github.com/nim65s/robotpkg/commit/a7212cbf7bb496db5bd2ede01d59ecdf18ac306e
For all of those commits, build and unit test of most gepetto packages have been checked in 14.04, 16.04, 18.08, fedora 27, fedora 28 & arch, both in python 2 & python 3, with ubuntu on Qt 4 and fedora / arch on Qt 5.
Integration tests have also been run in 16.04, 18.04 & arch, also in python 2 & python 3, with ubuntu on Qt 4 & arch on Qt 5.
Still, I was trying to set PREFER.omniORB = robotpkg when we are on ubuntu and on python 3, so I tried in 0730604de8f6510f62177c6b120a5029e8a0ea37 with :
ifeq (Ubuntu,${OPSYS}) ifneq (,$(filter python34 python35 python36 python37,${DEPEND_USE})) PREFER.omniORB?= robotpkg endif endif
But it doesn't seem to work, as I had to add PRFER.omniORB=robotpkg to my robotpkg.conf.
I think that as omniORB & omniORBpy were on PREFER=system, the changes I made should not break other packages that depends on them, but I did not check that further for now.
Cheers,
Guilhem.