Pull request #186
closedUpdate py-eigenpy to v1.5.0 and pinocchio / py-pinocchio to v1.3.3
Description
Hi,
In the branch https://github.com/nim65s/robotpkg/commits/eigenpy150, you will find 3 main commits to:
- update eigenpy to v1.5.0: https://github.com/nim65s/robotpkg/commit/7cada72553f8fb41d1ed18cbc3d63c6a3f58424a
- update pinocchio to v1.3.3: https://github.com/nim65s/robotpkg/commit/b9d3d07969c9966b7d87af1e7ebb05c4b6ef7b38
- update py-pinocchio to v1.3.3: https://github.com/nim65s/robotpkg/commit/728193ed5ea8da19fae781ca3b91f2c252feb919
And 4 commits for smaller changes, mostly in mk/sysdep:
- [math/pinocchio] fix SYSTEM_SEARCH for future versions: https://github.com/nim65s/robotpkg/commit/02506212259c3b63817de087e15fc9b2812d9ec9
for this, ref https://github.com/stack-of-tasks/pinocchio/issues/572
- [mk/sysdep] Add SYSTEM_DESCR & SYSTEM_PKG for 4 packages: https://github.com/nim65s/robotpkg/commit/c23545ea65688d766d44e03bf189855b7f440c4e
- [graphics/gepetto-viewer-corba] use QT5 in Arch: https://github.com/nim65s/robotpkg/commit/fbed6558e06445346493fdb061a515f3aa724cfa
because openscenegraph-qt is for qt5 in Arch
- [mk/sysdep] update SYSTEM_SEARCH.qt5-base: https://github.com/nim65s/robotpkg/commit/0ba1b6520679db9c76da74c260de2a045aa9d283
All of this has been succesfully tested by building hpp-tutorials and all of its dependencies on ubuntu 16.04, fedora 28 & Arch.
Updated by Guilhem Saurel over 5 years ago
For the records, after discussions, the branch https://github.com/nim65s/robotpkg/commits/eigenpy150 has been updated with minor changes.
Also, the commit "[graphics/gepetto-viewer-corba] use QT5 in Arch" should be replaced by a system allowing to choose ALTERNATIVE-ly qt4 or qt5, with a PREFER that could change depending on the distrib.
Updated by Guilhem Saurel over 5 years ago
Hi,
When I try to install gepetto-viewer-corba in Arch, I have this error:
found: /usr/include/osgQt/Export, wrong version 0
Here is the Export file: https://pastebin.com/AsdFVvTe
To check Qt version from osgqt, I'll say that for Qt5 we can find a lib/pkgconfig/openscenegraph-osgQt5.pc file, as it is defined upstream: https://github.com/openscenegraph/osgQt/blob/master/src/osgQt/CMakeLists.txt#L8-L13
Updated by Anthony Mallet over 5 years ago
On Tuesday 20 Nov 2018, at 15:27, Guilhem Saurel wrote:
To check Qt version from osgqt, I'll say that for Qt5 we can find a
lib/pkgconfig/openscenegraph-osgQt5.pc file, as it is defined
upstream:
https://github.com/openscenegraph/osgQt/blob/master/src/osgQt/CMakeLists.txt#L8-L13
This is only recently commited (after 3.5.5) and not even released
yet, so this won't help in the short term.
On the other hand, I see that the freshly added "Version" header is
removed by those recent commits. They don't seem to know what they are
doing ...
Updated by Anthony Mallet over 5 years ago
On Tuesday 20 Nov 2018, at 15:27, Guilhem Saurel wrote:
When I try to install gepetto-viewer-corba in Arch, I have this
error: found: /usr/include/osgQt/Export, wrong version 0
By default, Qt5 is preferred in PREFER_ALTERNATIVE.qt.
And it is assumed that osgQt is compiled with Qt4 if the "Version"
header is not found (because the apparition of this header corresponds
to commits fixing build with Qt5, so I assume Qt5 builds were not
possible before).
So:
- which Qt version did you select?
- which Qt version is used for osgQt on your system?
- which osgQt version is provided on your system?
Updated by Guilhem Saurel over 5 years ago
- which Qt version did you select?
PREFER_ALTERNATIVE.qt is qt5
- which Qt version is used for osgQt on your system?
Qt5
- which osgQt version is provided on your system?
I packaged 3.5.7 here: https://aur.archlinux.org/packages/osgqt/
Version has been dropped there: https://github.com/openscenegraph/osgQt/pull/4
Maybe another option way be to package osgQt in robotpkg, by linking the PREFER_ALTERNATIVE.qt flag to the DESIRED_QT_VERSION cmake option ?
And since 3.5.7 and https://github.com/openscenegraph/osgQt/pull/3 it should be possible to have both side-by-side.
Updated by Anthony Mallet over 5 years ago
On Wednesday 21 Nov 2018, at 16:32, Guilhem Saurel wrote:
I packaged 3.5.7 here: https://aur.archlinux.org/packages/osgqt/
OK. Somehow I missed that there were newer releases than 3.5.5.
The github repo is a bit strange, as it says "forked from ...". I only
checked the original repo for releases, as I tend to no trust "forks".
Anyway ...
Version has been dropped there:
https://github.com/openscenegraph/osgQt/pull/4
OK, let's forget about this transient header, then.
Maybe another option way be to package osgQt in robotpkg
This is too much of a hassle, I would say, as it requires users to be
super clean about what they do when installing the robotpkg version
while a system version exists. But it's an option, in case nothing
else works.
So what if mk/sysdep/osg-qt.mk simply assumes:
- Qt4 for lib/pkgconfig/osgQt.pc and libosgQt.so
- Qt5 for lib/pkgconfig/osgQt5.pc and libosgQt5.so
Except on Arch, I have no other example of distributions providing
osgQt compiled with Qt5 so far (ubuntu 19.04 dev and Fedora 30 are
still with Qt4), so this should work, at least for now.
Updated by Guilhem Saurel over 5 years ago
So what if mk/sysdep/osg-qt.mk simply assumes:
- Qt4 for lib/pkgconfig/osgQt.pc and libosgQt.so
- Qt5 for lib/pkgconfig/osgQt5.pc and libosgQt5.so
This would be perfect for me, thanks
Updated by Guilhem Saurel over 5 years ago
Hi,
Here is one last commit to make it work:
https://github.com/nim65s/robotpkg/commit/4fdead475c583ca1c5b5c9df43e7a4cee6e98338
Updated by Anthony Mallet over 5 years ago
On Thursday 22 Nov 2018, at 16:41, Guilhem Saurel wrote:
Here is one last commit to make it work:
https://github.com/nim65s/robotpkg/commit/4fdead475c583ca1c5b5c9df43e7a4cee6e98338
Pushed, thanks!
A minor glitch: your commit using PREFER_ALTERNATIVE.qt for USE_QT4 in
the Makefile was wrong. One need to use the actual qt alternative
selection, which is in PKG_ALTERNATIVE.qt (but you were right in
spotting a typo there :)
Updated by Guilhem Saurel over 5 years ago
- Status changed from Feedback to Resolved
Thanks, this is done for this issue then :)
Updated by Guilhem Saurel over 5 years ago
- Status changed from Resolved to Closed