Pull request #181
closed
Well done for spotting the typo in python36.mk ...
Shouldn't line 130 of mk/sysdep/python.mk be:
+ else ifeq (ArchLinux,${OPSYS})
Otherwise, this means that there is an inconsistency with the file name
mk/platform/ArchLinux.mk, which should be named mk/platform/Arch.mk
instead.
Also, lines 123-125 are useless, since this is the default. But I
agree that they might become useful when/if python37 becomes the
default.
About the line 130, I found it with
$ make show-var VARNAME=OPSYS
Arch
And if I run opsys.sh:
Arch rolling x86_64
in this file, the test looking for /etc/arch-release is not run, becaus the test with /etc/lsb-release is before, and in /etc/lsb release I have:
LSB_VERSION=1.4
DISTRIB_ID=Arch
DISTRIB_RELEASE=rolling
DISTRIB_DESCRIPTION="Arch Linux"
About the line 123-125, I let you choose :)
The /etc/lsb_release is owned by the community/lsb-release package, which is not mandatory.
If I remove it:
$ sh opsys.sh
ArchLinux 4.18.16-arch1-1 x86_64
$ make show-var VARNAME=OPSYS
ArchLinux
- Status changed from New to Closed
Also available in: Atom
PDF