Project

General

Profile

Actions

Pull request #181

closed

Python 3.7

Added by Guilhem Saurel over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Repository URL:
Repository branch:

Description

Hi,

Here is a commit to add support for python3.7:
https://github.com/nim65s/robotpkg/commit/02451dc51c702e129f9f3f8a657a3f2222344446

Best,
Guilhem.

Actions #1

Updated by Guilhem Saurel over 5 years ago

Oops, I forgot some files in an amend, please use this one:
https://github.com/nim65s/robotpkg/commit/cb198a45a2b83183019f9dd8074a3bb5498833b8

Actions #3

Updated by Anthony Mallet over 5 years ago

Well done for spotting the typo in python36.mk ...

Shouldn't line 130 of mk/sysdep/python.mk be:
+ else ifeq (ArchLinux,${OPSYS})

Otherwise, this means that there is an inconsistency with the file name
mk/platform/ArchLinux.mk, which should be named mk/platform/Arch.mk
instead.

Also, lines 123-125 are useless, since this is the default. But I
agree that they might become useful when/if python37 becomes the
default.

Actions #4

Updated by Guilhem Saurel over 5 years ago

About the line 130, I found it with
$ make show-var VARNAME=OPSYS
Arch

And if I run opsys.sh:
Arch rolling x86_64

in this file, the test looking for /etc/arch-release is not run, becaus the test with /etc/lsb-release is before, and in /etc/lsb release I have:
LSB_VERSION=1.4
DISTRIB_ID=Arch
DISTRIB_RELEASE=rolling
DISTRIB_DESCRIPTION="Arch Linux"

About the line 123-125, I let you choose :)

Actions #5

Updated by Guilhem Saurel over 5 years ago

The /etc/lsb_release is owned by the community/lsb-release package, which is not mandatory.
If I remove it:
$ sh opsys.sh
ArchLinux 4.18.16-arch1-1 x86_64
$ make show-var VARNAME=OPSYS
ArchLinux

Actions #7

Updated by Guilhem Saurel over 5 years ago

Or this one: https://github.com/nim65s/robotpkg/commit/b37c0b58b14cb8a09ee3230a6307b3e65f7d3850
This way opsys.sh gives the same result, whether the package lsb_release is installed or not

Actions #8

Updated by Anonymous over 5 years ago

  • Status changed from New to Closed
Actions

Also available in: Atom PDF