Project

General

Profile

Actions
Copy link

Pull request #416

closed

omniorb 3.2.4

Added by Guilhem Saurel 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Repository URL:
https://github.com/nim65s/robotpkg
Repository branch:
master

Description

Hi,

I noticed omniorbpy is not building on 24.04: http://robotpkg.openrobots.org/rbulk/robotpkg/middleware/py-omniORBpy/py312-omniORBpy-4.2.4/Ubuntu-24.04-x86_64/bulk.html, with what seems to be lacking of python 3.12 support:

pyMarshal.cc:2981:21: error: 'PyUnicode_FromUnicode' was not declared in this scope; did you mean 'PyUnicode_FromString'?

So here is an upgrade, and it is building fine on Arch which is also on python 3.12.

Actions
Copy link
 #1

Updated by Anthony Mallet 4 months ago · Edited

Right in time! I was about to start looking into this. Thanks!

However I have an issue with patch-ae (removed). Did you remove it on
purpose?

Actions
Copy link
 #2

Updated by Anthony Mallet 4 months ago

Namely:

--- PLIST       2024-06-20 14:32:26.905731294 +0200
+++ PLIST.guess 2024-06-20 14:38:59.427046702 +0200
@@ -242,10 +242,10 @@
lib/libomnithread.a
lib/libomnithread.so
lib/libomnithread.so.4
-lib/libomnithread.so.4.1
-lib/omniidl/_omniidl${PYTHON_EXT_SUFFIX}
-lib/omniidl/_omniidl${PYTHON_EXT_SUFFIX}.4
-lib/omniidl/_omniidl${PYTHON_EXT_SUFFIX}.4.2
+lib/libomnithread.so.4.3
+lib/omniidl/_omniidl.cpython-38-x86_64-linux-gnu.so
+lib/omniidl/_omniidl.cpython-38-x86_64-linux-gnu.so.4
+lib/omniidl/_omniidl.cpython-38-x86_64-linux-gnu.so.4.3
lib/omniidl/omniidl/__init__.py
lib/omniidl/omniidl/idlast.py
lib/omniidl/omniidl/idltype.py
Actions
Copy link
 #3

Updated by Anthony Mallet 4 months ago

Sorry, I misread the diff, patch-ae is not removed. I'll look more
deeply into this issue, then.

Actions
Copy link
 #4

Updated by Anthony Mallet 4 months ago

My bad, that's just print-PLIST that is tricky in this case. I should
sleep more ;)

  • etc/omniORB.cfg is managed by the INSTALL script in
    omniORB/files/config, so it must not be listed in PLIST, but
    print-PLIST is not aware of this.
  • PYTHON_EXT_SUFFIX is only replaced by print-PLIST in $PYTHON_SITELIB/,
    so as expected it must be put back in PLIST manually for the one .so
    outside this directory.

In the end, there was only a small glitch with the .so version
numbers. Fixed.

Actions
Copy link
 #5

Updated by Guilhem Saurel 4 months ago

  • Status changed from New to Closed

looks good now, thanks a lot !

Actions
Copy link

Also available in: Atom PDF