Pull request #228
closedPython 3.8 & dependency inclusion
Description
Hi,
This branch contains 5 commits to
- Teach robotpkg about python3.8, and set it as default on arch
- clean inclusion of depend.mk in various projects, moving them from Makefile to depend.mk where this makes sense
- update the version detection rule for pinocchio ahead of the new release not yet available in robotpkg (all other projects depending on the jrl-cmakemodules will have to follow)
- remove a required dependency on an outdated project
- fix a typo to allow make checkout
This has been tested on 16.04, 18.04 and Arch in python 2 & 3.
Cheers,
Guilhem.
Updated by Anthony Mallet over 4 years ago
In b30fc086 you remove dependencies that are required by
packages. Why? This will most probably break.
Also, changing dependencies typically requires a PKGREVISION bump, and
it's cleaner to have a commit per package (or at least group of
related packages).
Updated by Anthony Mallet over 4 years ago
Regarding 4e3a057 (py-crypto), the dependency was introduced in
ros-melodic and is required for rosbag.
Updated by Guilhem Saurel over 4 years ago
Hi,
py-crypto has been replaced by py-cryptodome both in ros_comm:
https://github.com/ros/ros_comm/pull/1609/files
and in Arch:
https://lists.archlinux.org/pipermail/arch-dev-public/2018-August/029352.html
py-crypto's upstream is dead and has a CVE, but it is still maintained by Debian, where the CVE is patched:
https://security-tracker.debian.org/tracker/CVE-2013-7459
Here is a commit for that:
https://github.com/nim65s/robotpkg/commit/3a39beae5b155ea42a6104715f3bbd7533f11540
While here, there are 3 similar commits after this one in https://github.com/nim65s/robotpkg/tree/topic/sysdeps
Updated by Guilhem Saurel over 4 years ago
Hum, my last message was very misleading.
https://github.com/nim65s/robotpkg/commit/3a39beae5b155ea42a6104715f3bbd7533f11540 just update SYSTEM_PKG.Arch with an up-to-date hint :)
Updated by Anthony Mallet over 4 years ago
OK, merged https://github.com/nim65s/robotpkg/tree/topic/sysdeps
Thanks!