Project

General

Profile

Actions

Pull request #417

open

Pinocchio 3

Added by Guilhem Saurel 19 days ago. Updated 17 days ago.

Status:
New
Priority:
Normal
Assignee:
-
Repository URL:
https://github.com/nim65s/robotpkg
Repository branch:
master

Description

Hi,

Pinocchio 3 is finally here. Most compatiblity issues were fixed, so we also need to:
- release crocoddyl 2.1.0
- release HPP 5.1.0
- patch example-robot-data

While here:
- update eigenpy to 3.7.0
- update proxsuite to 0.6.5
- update arch python to 3.12

This also leads to:
- archiving all rbprm packages: they won't have 5.1.0 version, and I think they can be removed from wip.
- break a few other things, but I will handle that later, namely: multicontact-api, sot-talos-balance, sot-torque-control, talos-torque-control.
- few broken things on 24.0
- a failing unittest on pinocchio 3 on 24.04, but I don't think this is an issue for us.

Best,
Guilhem.

Actions #1

Updated by Anthony Mallet 19 days ago

Thanks!

Quick comment: I think it's missing optimization/py-proxsuite.
One way to ease updates in this case is to have
optimization/proxsuite/Makefile.common with just the version and the
few common things.

Actions #2

Updated by Guilhem Saurel 19 days ago

Well spotted thanks !
I pushed it.

I'm not sure abot the Makefile.common, as changes in distinfo and PLIST are also required, so this won't prevent me to forget something like that, I think

Actions #3

Updated by Anthony Mallet 18 days ago

For DISTINFO, you could set DISTINFO_FILE to
${ROBOTPKG_DIR}/optimization/proxsuite so that it's shared with the
main package. But yes, for the PLIST it still needs it own PLIST, even
though it should not change much over time?

Anyway, just pushed your commit.

Actions #4

Updated by Guilhem Saurel 17 days ago

but this distinfo might not be the same, if we apply a different patch set on the different packages.

rbprm packages were not in wip anymore, so I pushed another commit to drop them.

I also pushed a patch to pinocchio for some console_bridge issues, but I can't test that right now.

and for gepetto-viewer, I can't download the logs to see what is wrong there :/

Actions #5

Updated by Anthony Mallet 17 days ago · Edited

On Wednesday 3 Jul 2024, at 12:49, Guilhem Saurel wrote:

but this distinfo might not be the same, if we apply a different
patch set on the different packages.

Correct, good point. I think it's good enough as it is, then.

rbprm packages were not in wip anymore, so I pushed another commit
to drop them.

I also pushed a patch to pinocchio for some console_bridge issues,
but I can't test that right now.

Ok, will push that.

and for gepetto-viewer, I can't download the logs to see what is
wrong there :/

I also noticed that some logs can't be downloaded (depending on the
browser version, maybe, as I still could see them at home). It might
be because the logs are merely encapsulated by a html <div> but not a
<pre>, so there might be confusing syntax in there.

The error for py-qt-gepetto-viewer is a PLIST error:
robotpkg_create: can't stat `/opt/openrobots/lib/gepetto-gui-plugins/pyqgv.so'

If you confirm this plugin does not exist anymore, and can just drop
the line from the PLIST while pushing your other commits.

Actions

Also available in: Atom PDF