Project

General

Profile

Actions

Pull request #184

closed

Update omniORB & omniORBpy to 4.2.2

Added by Guilhem Saurel over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Repository URL:
Repository branch:

Description

Hi,

Following discussions in
https://github.com/Gepetto/gepetto-viewer-corba/issues/85, we would like to update omniORB to 4.2.2, to add python 3 support.

These commits https://github.com/nim65s/robotpkg/tree/omniorb will update omniORB, but not yet enable python3 support, because I am not sure about how to do it properly in the robotpkg environment. Maybe should we add ${PKGTAG.python-} to the PKGNAME ? Or could we the package for both python2 & python 3

Actions #1

Updated by Anthony Mallet over 5 years ago

The default PREFER.omniORB on ubuntu 18.04 should not be 'robotpkg',
as this would create a big mess for people normally installing it via
system packages - and it would as a side effect create binary packages
pulling a custom version of omniORB.

Actions #2

Updated by Anthony Mallet over 5 years ago

Also, middleware/omniORB and middleware/omniORBpy should be in sync.
It looks like you only updated middleware/omniORBpy.

Actions #3

Updated by Guilhem Saurel over 5 years ago

I updated both:
- omniORB https://github.com/nim65s/robotpkg/commit/279f087fa29d681f5f8b0ec5cdc674f7c40eddb5
- omniORBpy https://github.com/nim65s/robotpkg/commit/1ed1a91be34ce1879415120a9685a6e8943989b8

About the PREFER, I don't really mind, as long as we can build packages with the python 3 version :)

Actions #4

Updated by Anthony Mallet over 5 years ago

On Friday 26 Oct 2018, at 12:12, Guilhem Saurel wrote:

https://github.com/nim65s/robotpkg/commit/279f087fa29d681f5f8b0ec5cdc674f7c40eddb5

Sorry, I missed that one ...

Actions #5

Updated by Joseph Mirabel over 5 years ago

I do not know if it is possible to have simultaneously omniORB with python 2 and 3. The issue comes with omniidl (part of omniORBpy) which installs files in /usr/lib/omniidl/ regardless of the version of Python.

It will work only if theses files are compatible with Python 2 and 3. I believe the libraries won't be and the Python files will.

Actions #6

Updated by Guilhem Saurel over 5 years ago

Then, we could either patch a few things to put omniidl in a path dependent of the python version, or rename it omniidl-py2 / omniidl-py3, or rename the packages to be robotpkg-py27-omniorb / robotpkg-py35-omniorb and set them incompatible to each other.

Actions #7

Updated by Anthony Mallet over 5 years ago

On Friday 26 Oct 2018, at 16:11, Joseph Mirabel wrote:

I do not know if it is possible to have simultaneously omniORB with
python 2 and 3. The issue comes with omniidl (part of omniORBpy) which
installs files in /usr/lib/omniidl/ regardless of the version of
Python.

This is the debian packaging that installs files to /usr/lib/omniidl
for omniORBpy. robotpkg (or rather omniORBpy by default) installs them
in an appropriate location (PYTHON_SITELIB).

omniidl is however not part of omniORBpy, it's from omniORB. The fact
that omniidl is implemented in python is unrelated (although bringing
in a lot of confusion) to the omniORBpy target python version. For
instance, on ubuntu-18.04, omniidl uses python3 as it's interpreter,
but python-omniorb is for python2 (don't ask why).

It happens sometimes that a package is implemented in python (which
is an internal concern) and also produces or deal with python
code (I'm looking at sphinx or morse). Then the two python versions
are in principle unrelated, but in practice it's a mess to separate
the two. In particular, robotpkg cannot depend on more than one python
version for a package.

Actions #8

Updated by Guilhem Saurel over 5 years ago

  • Status changed from New to Closed

I checked that we can now get gepetto-viewer-corba (on the devel branch, with minor updates) working with python3, so it's OK for me, thanks !

Actions

Also available in: Atom PDF