Project

General

Profile

Actions

Pull request #454

closed
GS

Bumps

Pull request #454: Bumps

Added by Guilhem Saurel 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Repository URL:
https://github.com/nim65s/robotpkg
Repository branch:
master

Description

Hi,

We have many new releases, with 2 major changes:
- jrl-cmakemodules is now packaged on its own, instead of being included as submodule
- splitting python bindings from main package is managed by jrl-cmakemodules argument "BUILD_STANDALONE_PYTHON_INTERFACE"

Cheers,
Guilhem

AM Updated by Anthony Mallet 3 months ago Actions #1

Thanks!

I noticed that in bb8bfab [math/eiquadprog] comments you mention patch-aa but
it's not included in the commit. Either the patch is missing or the
comment is wrong?

GS Updated by Guilhem Saurel 3 months ago Actions #2

The commit message is obsolete, I was wrong on this patch and I was able to remove it afterwards

AM Updated by Anthony Mallet 3 months ago Actions #3

I have this error on different systems (ubuntu-24.04, netbsd-10),
which I don't know how to fix.
Any idea?

/tmp/mallet/robotpkg/math/hpp-pinocchio/work.hydra64-netbsd10/hpp-pinocchio-6.1.0/src/joint/bound.hh:44:37: error: no type named 'type' in 'struct hpp::pinocchio::RnxSOnLieGroupMap::operation<pinocchio::JointModelEllipsoidTpl<double> >'
43 |     ::hpp::pinocchio::RnxSOnLieGroupMap::template operation<
|     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
44 |         JointModel>::type ::setBound(bounds, jmodel.jointConfigSelector(out));
|         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

GS Updated by Guilhem Saurel 3 months ago Actions #4

Oh, yes, my bad. I've added a commit with a patch for this.

This was initially intended to ensure build would fail to force us to properly define required things, but it appear that we don't care anymore about a few cases we won't use and it is better if the project just build fine.

AM Updated by Anthony Mallet 3 months ago Actions #5

OK. Looks good enough, I just pushed (with some minor and mostly
cosmetic changes). Let's see!

Thanks

GS Updated by Guilhem Saurel 3 months ago Actions #6

Thannks for the push and the fixes, everything looks fine now :)

GS Updated by Guilhem Saurel 3 months ago Actions #7

  • Status changed from New to Resolved

GS Updated by Guilhem Saurel 3 months ago Actions #8

  • Status changed from Resolved to Closed
Actions

Also available in: PDF Atom