Project

General

Profile

Actions

Pull request #441

open
GS

Minor bumps

Pull request #441: Minor bumps

Added by Guilhem Saurel over 1 year ago. Updated over 1 year ago.

Status:
New
Priority:
Normal
Assignee:
-
Repository URL:
https://github.com/nim65s/robotpkg
Repository branch:
master

Description

Hi,

Here are some updates of the usual suspects.

Is also add some basic NixOS support, where qhull is the re-entrant version libqhull_r.so, and where boost is 1.87, so math/py-pinocchio/patches/patch-al can't use boost::asio::buffer_cast anymore.

Best,
Guilhem

AM Updated by Anthony Mallet over 1 year ago Actions #1

Thanks!

Pushed, with just a rewording of the commit regarding qhull.

GS Updated by Guilhem Saurel over 1 year ago Actions #2

Not sure what to do about the share/coal/hook/python_path.dsv in py-coal PLIST warning.

This file is supposed to allow ament to find the python module, but I don't know why or how.

If this is fine to remove it, we can pass BUILDING_ROS2_PACKAGE=OFF in devel/jrl-cmakemodules/Makefile.common's USE_PYTHON.

Otherwise, it can be added to PLIST, but there will be a collision on multiple python versions.

AM Updated by Anthony Mallet over 1 year ago Actions #3

AFAICT, python_path.dsv just contains the PYTHON_SITELIB. As this
package is installed in a usual python path, it should not be very
useful, so it could be dropped.

On the other hand, it might be (to be checked) that ament (colcon?) will
process any .dsv file in the <package>/hook directory. So the file
could be named "pythonNN_path.dsv", with NN being the python version.
(what happens then with ament if multiple python versions are
installed is left as an exercise to the reader).

Last idea: it seems to me that
share/ament_index/resource_index/packages/<package> could be used with
a <package> name like "pyNN-coal" for the python part. I guess that
ament (colcon?) will then look for any share/<package>/hook for
all packages in share/ament_index/resource_index/packages.
The installation path of python_path.dsv could then be
'share/pyNN-coal/python_path.dsv'.
Also to be checked.

As a related item:
share/ament_index/resource_index/packages/coal
share/coal/hook/ament_prefix_path.dsv
are installed by path/coal and seems to be overriden by
path/py-coal. Not sure why.

Actions

Also available in: PDF Atom