Pull request #369
closedUpdate HPP, pinocchio & TSID
Description
hello,
This time I've condensed all HPP updates into a single commit, but it can be undone if necessary.
Best,
Guilhem
Updated by Anthony Mallet over 1 year ago
On Friday 21 Oct 2022, at 12:00, Guilhem Saurel wrote:
This time I've condensed all HPP updates into a single commit, but
it can be undone if necessary.
OK, I pushed it as is.
This is a bit less easy for people to follow the changes with a
monolitic commit, but for hpp I guess it's less painful like this. It
makes sense also in the sense that the different packages don't seem
modular, i.e. they are all bumped at the same time, and I'm not sure
what happens if you mix different versions together :)
Thanks!
Updated by Guilhem Saurel over 1 year ago
Hi,
It looks like we have a couple issues with gepetto viewer:
1. the icons are missing. It really wants the "doxygen" theme, I think this should be improved, but for now we can just declare this as a dependency.
2. I made an import order mistake.
Both points are adressed in the 3 commits pushed to my branch.
Updated by Anthony Mallet over 1 year ago
On Wednesday 2 Nov 2022, at 17:59, Guilhem Saurel wrote:
1. the icons are missing. It really wants the "doxygen" theme, I
think this should be
improved, but for now we can just declare this as a dependency.
OK, fine. I just renamed the icons dependency to match the upstream
distribution name (oxygen-icons).
Updated by Guilhem Saurel over 1 year ago
- Status changed from New to Closed
Everything looks fine, thanks !