Pull request #325
closedUpdate eigenpy, hpp-fcl & pinocchio
Description
Hi !
Everything is in the title :)
Cheers,
Guilhem.
Updated by Anthony Mallet over 2 years ago
Thanks, pushed.
(I was about to merge that in your previous request, but I was not
sure ...)
Updated by Guilhem Saurel over 2 years ago
Hello,
Yes, those were not already fully tested in the previous request :)
But we still have 2 issues.
The first is about eigenpy build in 16.04. I don't think we need to pay too much attention to it, so I added a patch that remove the lines triggering the error, in an unit-test.
The second is that the new version of pinocchio fixed a computation, which was already fixed in crocoddyl, so now crocoddyl applies the fix twice… So we removed the fix from crocoddyl, and I made a new release.
Best,
Guilhem
Updated by Anthony Mallet over 2 years ago
I added a patch that remove the lines triggering the error, in an
unit-test.
Applied. Although it's always a bit more clear to find the version of
eigen or numpy that triggers the issue (if it exists). Not a big deal
I guess.
So we removed the fix from crocoddyl, and I made a new release.
Applied as well,
Thanks!
Updated by Guilhem Saurel over 2 years ago
- Status changed from New to Closed
Yes, we could have made something cleaner. But this will be for the next release :)
Everything is OK now, thanks !