Project

General

Profile

Actions

Pull request #325

closed

Update eigenpy, hpp-fcl & pinocchio

Added by Guilhem Saurel about 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Repository URL:
https://github.com/nim65s/robotpkg
Repository branch:
master

Description

Hi !

Everything is in the title :)

Cheers,
Guilhem.

Actions #1

Updated by Anthony Mallet about 2 months ago

Thanks, pushed.
(I was about to merge that in your previous request, but I was not
sure ...)

Actions #2

Updated by Guilhem Saurel about 2 months ago

Hello,

Yes, those were not already fully tested in the previous request :)

But we still have 2 issues.
The first is about eigenpy build in 16.04. I don't think we need to pay too much attention to it, so I added a patch that remove the lines triggering the error, in an unit-test.

The second is that the new version of pinocchio fixed a computation, which was already fixed in crocoddyl, so now crocoddyl applies the fix twice… So we removed the fix from crocoddyl, and I made a new release.

Best,
Guilhem

Actions #3

Updated by Anthony Mallet about 2 months ago

I added a patch that remove the lines triggering the error, in an
unit-test.

Applied. Although it's always a bit more clear to find the version of
eigen or numpy that triggers the issue (if it exists). Not a big deal
I guess.

So we removed the fix from crocoddyl, and I made a new release.

Applied as well,
Thanks!

Actions #4

Updated by Guilhem Saurel about 2 months ago

  • Status changed from New to Closed

Yes, we could have made something cleaner. But this will be for the next release :)
Everything is OK now, thanks !

Actions

Also available in: Atom PDF