robotpkg

Thanks, pushed.

Debian 9 and Ubuntu 16.04 don't have libqhull-r. So I think we should just remove this option on those distro… Unless there is a nice way to add an automatic condition for this ?

For the issue on 21.04, this is something else, I'll have a look soon.

On Wednesday 23 Jun 2021, at 19:20, Guilhem Saurel wrote:

Debian 9 and Ubuntu 16.04 don't have libqhull-r. So I think we
should just remove this option on those distro… Unless there is a
nice way to add an automatic condition for this ?

The qhull sysdep is looking only for qhull.
What about looking for qhull_r as well?

this would make hpp-fcl unavailable on those distro, while it could be available as long as we don't activate this option (which only speed up some computations), as this was the case until now :/

Unless we package qhull on robotpkg, and put a PREFER on system on distro where we have this qhull_r, and robotpkg otherwise… I'll give this a try.

this would make hpp-fcl unavailable on those distro

Of course. So then yes, you can have a switch on the distribution.

(The idea is still to not have this automatic, so that the builds are
predictible and you get exactly what is configured.)

Unless we package qhull on robotpkg, and put a PREFER on system on

I'm not sure it's worth the pain for Ubuntu-16 (EOL) and debian 9
which is still alive but not for long ...

Qqhull has a custom license, so I won't investigate further. Should we try with https://github.com/nim65s/robotpkg/commit/8b235140a277dff1cf6dba9dec03db8f7ce5200b ?

Yes, kind of.
Although you should move the `sysdep/qhull.mk` inclusion inside the 'if'.
And use the OPSYS, OS_VERSION combination, like
`ifeq (,$(filter Ubuntu-16.04 Debian-9,${OPSYS}-${OS_VERSION}))`

You're right, https://github.com/nim65s/robotpkg/commit/893ceb5ee752755e29bd4f8c37a25a1895a6b91b seems to work better for stretch :)

Yep, seems OK at first sight!
Pushed

It looks OK :)

Here is another patch which should fix build with qhull on 21.04: https://github.com/nim65s/robotpkg/commit/307bd2a56227e47f758e656266f893e79de43a81

Pushed!