Project

General

Profile

Actions

Pull request #321

closed

Update example-robot-data to v3.10.0

Added by Guilhem Saurel about 2 months ago. Updated 14 days ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Repository URL:
https://github.com/nim65s/robotpkg
Repository branch:
master

Description

Hi,

Example-robot-data just got 2 new robots, so we can have a new release :)
While here, I think we can activate the use of Qhull by hpp-fcl, to improve its performances.

Best,
Guilhem.

Actions #1

Updated by Guilhem Saurel about 2 months ago

  • Repository URL set to https://github.com/nim65s/robotpkg
  • Repository branch set to master
Actions #2

Updated by Anthony Mallet about 2 months ago

Thanks, pushed.

Actions #3

Updated by Guilhem Saurel about 1 month ago

Debian 9 and Ubuntu 16.04 don't have libqhull-r. So I think we should just remove this option on those distro… Unless there is a nice way to add an automatic condition for this ?

For the issue on 21.04, this is something else, I'll have a look soon.

Actions #4

Updated by Anthony Mallet about 1 month ago

On Wednesday 23 Jun 2021, at 19:20, Guilhem Saurel wrote:

Debian 9 and Ubuntu 16.04 don't have libqhull-r. So I think we
should just remove this option on those distro… Unless there is a
nice way to add an automatic condition for this ?

The qhull sysdep is looking only for qhull.
What about looking for qhull_r as well?

Actions #5

Updated by Guilhem Saurel about 1 month ago

this would make hpp-fcl unavailable on those distro, while it could be available as long as we don't activate this option (which only speed up some computations), as this was the case until now :/

Actions #6

Updated by Guilhem Saurel about 1 month ago

Unless we package qhull on robotpkg, and put a PREFER on system on distro where we have this qhull_r, and robotpkg otherwise… I'll give this a try.

Actions #7

Updated by Anthony Mallet about 1 month ago

this would make hpp-fcl unavailable on those distro

Of course. So then yes, you can have a switch on the distribution.

(The idea is still to not have this automatic, so that the builds are
predictible and you get exactly what is configured.)

Unless we package qhull on robotpkg, and put a PREFER on system on

I'm not sure it's worth the pain for Ubuntu-16 (EOL) and debian 9
which is still alive but not for long ...

Actions #8

Updated by Guilhem Saurel about 1 month ago

Qqhull has a custom license, so I won't investigate further. Should we try with https://github.com/nim65s/robotpkg/commit/8b235140a277dff1cf6dba9dec03db8f7ce5200b ?

Actions #9

Updated by Anthony Mallet about 1 month ago

Yes, kind of.
Although you should move the `sysdep/qhull.mk` inclusion inside the 'if'.
And use the OPSYS, OS_VERSION combination, like
`ifeq (,$(filter Ubuntu-16.04 Debian-9,${OPSYS}-${OS_VERSION}))`

Actions #11

Updated by Anthony Mallet about 1 month ago

Yep, seems OK at first sight!
Pushed

Actions #12

Updated by Guilhem Saurel about 1 month ago

It looks OK :)

Here is another patch which should fix build with qhull on 21.04: https://github.com/nim65s/robotpkg/commit/307bd2a56227e47f758e656266f893e79de43a81

Actions #13

Updated by Anthony Mallet about 1 month ago

Pushed!

Actions #14

Updated by Guilhem Saurel 14 days ago

  • Status changed from New to Closed
Actions

Also available in: Atom PDF