Project

General

Profile

Actions

Pull request #196

closed

Update HPP to v4.3.0

Added by Guilhem Saurel about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Repository URL:
Repository branch:

Description

Hi,

The branch https://github.com/nim65s/robotpkg/commits/hpp43 updates HPP to v4.3.0.
It has been tested on Ubuntu 16.04, Fedora 28 & ArchLinux.

Cheers,
Guilhem.

Actions #1

Updated by Guilhem Saurel about 5 years ago

I tried with 18.04 and found a few issues. 3 of them are already fixed and push on the same branch, and I am currently working on a fourth one.
About 14.04 and less, as this is not supported upstream, I am not sure what we should do.

Actions #2

Updated by Anthony Mallet about 5 years ago

On Monday 4 Feb 2019, at 18:08, Guilhem Saurel wrote:

I tried with 18.04 and found a few issues. 3 of them are already fixed
and push on the same branch, and I am currently working on a fourth
one.

OK, update this issue when you'll be done, then.

About 14.04 and less, as this is not supported upstream, I am
not sure what we should do.

This is not so much about "14.04" or a distribution version rather
than about the version of the actual dependencies.
If you put the appropriate dependencies requirements, this will work.

Actions #3

Updated by Guilhem Saurel about 5 years ago

Hi,

Some packages have been updated to 4.3.1 to fix build on 18.04 in new commits on the same branch.

About 14.04, I think you already explained that to me, but this time I understand it, thanks :)
Still, I also pushed a patch to make hpp-fcl compile again with eigen < 3.2.1, in order to allow compilation on 14.04 which has 3.2.0.
For other HPP softwares, the DEPEND_ABI.eigen3 is already correctly set.

I don't see other issues with this PR.

Actions #4

Updated by Guilhem Saurel about 5 years ago

FYI, I updated this branch once again, to fix a patch in hpp-corbaserver, which was preventing some files from beeing installed.

Actions #5

Updated by Anthony Mallet about 5 years ago

On Wednesday 6 Feb 2019, at 18:29, Guilhem Saurel wrote:

FYI, I updated this branch once again, to fix a patch in
hpp-corbaserver, which was preventing some files from beeing
installed.

OK, got it.

I pushed most of the commits (merged successive updates into a
single commit, since having separate commits did not provide much more
info). I just had to fix a few PLISTs.

For now, I removed your attempt to set a "test" and "coverage" option,
because this does not fit well with the option semantics: test and
coverage do not provide different packages in the end, so I prefer to
not implement this with options (in general, options are painful).

What could/should be done is to provide a general "test" target in
robotpkg, as "build" or "install". This could be implemented by
packages, like what you did for the option. This is a separate issue
anyway.

Actions #6

Updated by Guilhem Saurel about 5 years ago

  • Status changed from New to Closed

\o/

Thanks a lot !

I'll work again on those options, there is no hurry, and yes, this has nothing to do with the current PR.

Actions

Also available in: Atom PDF