Project

General

Profile

Pull request #191

[mk/sysdep/qmake.mk] fix / factorize version detection for Qt 4 & 5

Added by Guilhem Saurel 5 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Repository URL:
Repository branch:

Description

Hi,

This commit
https://github.com/nim65s/robotpkg/commit/2cf2442afeb5e8554d3c4c8fdd4548d686c8a00d
fixes the detection of qmake, at least in 16.04, where I got `found:▷·/usr/bin/qmake, wrong version 0` while trying to build ros-python-qt-bindings

Associated revisions

Revision 5194f256 (diff)
Added by Anthony Mallet 2 months ago

[mk/sysdep] Fix QT_SELECT when depending on a specific Qt version directly

Export QT_SELECT from qt4-libs.mk or qt5-qtbase.mk directly, instead of pulling
the Qt alternative selection from those files. If one depends on a Qt version
directly, there is no point in having the Qt alternative selection.

This fixes #191 (qmake version detection).

History

#1

Updated by Anthony Mallet 4 months ago

QT_SELECT is only defined (so far) when using the 'qt' alternative, so
your change alone would break most packages (that depend directly on a
qt version). E.g. ros-python-qt-binding depends on qt5-qtbase.

As far as I can see, the bulk builds on ubuntu 16.04 are fine, so
could you provide more info regarding your issue?

#2

Updated by Anthony Mallet 2 months ago

  • Status changed from New to Closed

Also available in: Atom PDF